Copy OSS info if checksum matches #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soimkim
reviewed
Jul 13, 2025
| if nvd_url and len(nvd_url) > MAX_EXCEL_URL_LENGTH: | ||
| oss.comment = f"Exceeded the maximum vulnerability URL length of {MAX_EXCEL_URL_LENGTH} characters." | ||
| if EXCEEDED_VUL_URL_LENGTH_COMMENT not in oss.comment: | ||
| oss.comment = EXCEEDED_VUL_URL_LENGTH_COMMENT |
Contributor
There was a problem hiding this comment.
@bjk7119 , 이 방법보다 중복으로 찍히는 로직을 확인하는 것을 제안드립니다.
재현이 불가하셔서 로직 내 중복 원인이 확인되지 않는 상태인가요?
soimkim
reviewed
Jul 13, 2025
soimkim
reviewed
Jul 13, 2025
| dup_bin = None | ||
| for bin in bins: | ||
| if bin.oss_items and len(bin.oss_items) > 0: | ||
| dup_bin = bin |
Contributor
There was a problem hiding this comment.
이렇게 세팅하면 Binary DB을 load한 binary인지, OWASP에서 값을 읽어온 binary인지 구분이 되나요?
그리고 OWASP에서 값을 읽어온 binary의 값을 copy시, Comment 도 "OWASP result"로 바뀌는 것인지 문의드립니다. (코드 상으로는 안 바뀔 것 같아서요)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change